Experiment reusable ci workflow #123
Conversation
pedro-psb
force-pushed
the
experiment-reusable-ci-workflow
branch
from
7fd51cf to
f7a4e22
Compare
pedro-psb
force-pushed
the
experiment-reusable-ci-workflow
branch
from
f7a4e22 to
fcb8e70
Compare
pedro-psb
force-pushed
the
experiment-reusable-ci-workflow
branch
from
02c7ee4 to
8c7aa64
Compare
pedro-psb
force-pushed
the
experiment-reusable-ci-workflow
branch
from
8c7aa64 to
a5fdbf8
Compare
.github/workflows/docs-ci.yml
Outdated
| - name: "Build Docs" | ||
| working-directory: "pulp-docs" | ||
| run: | | ||
| pulp-docs fetch --dest /tmp/pulp-docs-tmp |
There was a problem hiding this comment.
Can we add the --path argument here too? So we don't fetch repositories we already have?
.github/workflows/docs-ci.yml
Outdated
| path: pulp-docs | ||
| # ref: "rewrite-as-mkdocs-plugin" | ||
| # TODO: revert. using this because pulpcore-selinux is not included in rewrite-as-mkdocs-plugin | ||
| ref: "experiment-reusable-ci-workflow" |
There was a problem hiding this comment.
Is it possible to fetch the tag of the reference we took the reusable workflow from?
There was a problem hiding this comment.
To my surprise, not very easily: actions/toolkit#1264
But there are some workarounds on the thread.
.github/workflows/docs-ci.yml
Outdated
| @@ -0,0 +1,65 @@ | |||
| name: 'Docs CI' | |||
There was a problem hiding this comment.
Let's write proper and safe yaml.
Start with --- end with ... and consistently quote all strings.
.github/workflows/docs-ci.yml
Outdated
| working-directory: "pulp-docs" | ||
| run: | | ||
| pulp-docs fetch --dest /tmp/pulp-docs-tmp | ||
| pulp-docs build --path pulp-docs@..:${{ github.event.repository.name }}@..:/tmp/pulp-docs-tmp |
There was a problem hiding this comment.
I don't even think we need handle pulp-docs specially here.
| pulp-docs build --path pulp-docs@..:${{ github.event.repository.name }}@..:/tmp/pulp-docs-tmp | |
| pulp-docs build --path ${{ github.event.repository.name }}@..:/tmp/pulp-docs-tmp |
There was a problem hiding this comment.
If we don't it will get pulp-docs docs from the /tmp/pulp-docs (actually it wont find it when we filter the fetch).
Co-authored-by: Matthias Dellweg <[email protected]>
pedro-psb
force-pushed
the
experiment-reusable-ci-workflow
branch
4 times, most recently
from
ce66066 to
1005d1f
Compare
pedro-psb
force-pushed
the
experiment-reusable-ci-workflow
branch
from
1005d1f to
aa0aa4d
Compare
Replaces #122
This one is on a pulp-docs branch so I can test the PR on other repositories.
Test PR in pulpcore-selinux: pulp/pulpcore-selinux#83